Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transformer): enable class-properties plugin #7750

Merged

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 9, 2024

Done!

Copy link
Member Author

Dunqing commented Dec 9, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 9, 2024
@Dunqing
Copy link
Member Author

Dunqing commented Dec 9, 2024

Copy link

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #7750 will not alter performance

Comparing 12-09-chore_transformer_enable_class-properties_plugin (e5ee38f) with 12-31-feat_transformer_class-properties_transform_private_in_expression (0592a8b)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 4e40a4e to 2da9cae Compare December 11, 2024 03:12
@Dunqing Dunqing changed the base branch from main to 12-11-fix_transformer_class-properties_panic_when_the_callee_or_member_is_parenthesisexpression_or_ts-syntax_expressions December 11, 2024 03:12
@Dunqing
Copy link
Member Author

Dunqing commented Dec 11, 2024

@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 2da9cae to 952027e Compare December 11, 2024 07:35
@Dunqing Dunqing changed the base branch from 12-11-fix_transformer_class-properties_panic_when_the_callee_or_member_is_parenthesisexpression_or_ts-syntax_expressions to 12-11-fix_transformer_class-properties_unwrap_failed_when_private_field_expression_doesn_t_contain_optional_expression_in_chainexpression December 11, 2024 07:35
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 952027e to 39c042c Compare December 11, 2024 07:38
@Dunqing
Copy link
Member Author

Dunqing commented Dec 11, 2024

@Dunqing Dunqing force-pushed the 12-11-fix_transformer_class-properties_unwrap_failed_when_private_field_expression_doesn_t_contain_optional_expression_in_chainexpression branch from b2bfacf to bcb1ea8 Compare December 11, 2024 07:47
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch 2 times, most recently from 2337edb to d05b53f Compare December 11, 2024 08:09
@overlookmotel overlookmotel force-pushed the 12-11-fix_transformer_class-properties_unwrap_failed_when_private_field_expression_doesn_t_contain_optional_expression_in_chainexpression branch 2 times, most recently from 6613461 to 4e479cb Compare December 11, 2024 11:20
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from d05b53f to e23abdf Compare December 11, 2024 11:20
@overlookmotel overlookmotel changed the base branch from 12-11-fix_transformer_class-properties_unwrap_failed_when_private_field_expression_doesn_t_contain_optional_expression_in_chainexpression to graphite-base/7750 December 11, 2024 11:32
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from e23abdf to 0cf4d99 Compare December 11, 2024 11:36
@overlookmotel overlookmotel changed the base branch from graphite-base/7750 to main December 11, 2024 11:37
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 0cf4d99 to d5aec18 Compare December 11, 2024 11:37
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from d5aec18 to 15c0218 Compare December 13, 2024 03:08
@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 15c0218 to f545650 Compare December 15, 2024 11:22
@overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from f545650 to 6f2ca00 Compare December 19, 2024 01:51
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 3acd63e to f181688 Compare December 28, 2024 16:18
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from 713db99 to 64b8f64 Compare December 29, 2024 01:57
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from f181688 to 6565f33 Compare December 29, 2024 01:57
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from 64b8f64 to 284522b Compare December 29, 2024 16:05
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 6565f33 to 583f042 Compare December 29, 2024 16:05
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from 284522b to db6c976 Compare December 30, 2024 07:11
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 583f042 to efb7eb7 Compare December 30, 2024 07:11
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from db6c976 to 55464b6 Compare December 31, 2024 09:33
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from 55464b6 to 211e9a7 Compare December 31, 2024 10:34
@Dunqing Dunqing force-pushed the 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods branch from 211e9a7 to b1ab06c Compare December 31, 2024 10:49
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from efb7eb7 to e5b74c0 Compare December 31, 2024 10:50
@Dunqing Dunqing changed the base branch from 12-26-feat_transformer_class-properties_transform_static_instance_accessor_methods to 12-31-feat_transformer_class-properties_transform_private_in_expression December 31, 2024 10:50
@Dunqing
Copy link
Member Author

Dunqing commented Dec 31, 2024

@Dunqing Dunqing force-pushed the 12-31-feat_transformer_class-properties_transform_private_in_expression branch from 1563017 to 26dad2f Compare December 31, 2024 11:03
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch 3 times, most recently from 0aa4bd7 to 706a366 Compare December 31, 2024 11:51
@Dunqing Dunqing marked this pull request as ready for review December 31, 2024 12:29
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 31, 2024
Copy link
Member Author

Dunqing commented Dec 31, 2024

Merge activity

  • Dec 31, 7:29 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 31, 7:29 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 31, 8:40 AM EST: A user merged this pull request with the Graphite merge queue.

@Dunqing Dunqing force-pushed the 12-31-feat_transformer_class-properties_transform_private_in_expression branch from 26dad2f to 0592a8b Compare December 31, 2024 12:38
@Dunqing Dunqing force-pushed the 12-09-chore_transformer_enable_class-properties_plugin branch from 706a366 to e5ee38f Compare December 31, 2024 12:38
Base automatically changed from 12-31-feat_transformer_class-properties_transform_private_in_expression to main December 31, 2024 13:37
@graphite-app graphite-app bot merged commit e5ee38f into main Dec 31, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 12-09-chore_transformer_enable_class-properties_plugin branch December 31, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants